Skip to content

qt515: update qtscript version #195166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tjni wants to merge 1 commit into from
Closed

qt515: update qtscript version #195166

tjni wants to merge 1 commit into from

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Oct 9, 2022

Description of changes

I hope this fixes issues like this one. Related to #193494.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested a review from ttuegel as a code owner October 9, 2022 01:49
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Oct 9, 2022
@tjni tjni marked this pull request as draft October 9, 2022 01:49
@tjni
Copy link
Contributor Author

tjni commented Oct 9, 2022

Setting as a draft until ofborg results come back.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Oct 9, 2022
@tjni tjni changed the title qt5: update qtscript version qt515: update qtscript version Oct 9, 2022
@tjni
Copy link
Contributor Author

tjni commented Oct 9, 2022

@ofborg build qt515

@tjni
Copy link
Contributor Author

tjni commented Oct 9, 2022

@ofborg build CuboCore

@tjni tjni marked this pull request as ready for review October 9, 2022 03:43
@LunNova
Copy link
Member

LunNova commented Oct 9, 2022

Introduced in dd4afc7

LunNova
LunNova reviewed Oct 9, 2022
View reviewed changes
@LunNova
Copy link
Member

LunNova commented Oct 9, 2022

cc @K900 since you added it

@tjni
Copy link
Contributor Author

tjni commented Oct 9, 2022

@ofborg build CuboCore

@K900
Copy link
Contributor

K900 commented Oct 9, 2022

Ugh. I forgot those existed, again. Should be good.

@vcunat
Copy link
Member

vcunat commented Oct 9, 2022

Ah, I'm sorry, I wasn't looking at PRs. I didn't expect you'd be so quick, so I just pushed the same as 7cce28d.

@vcunat vcunat closed this Oct 9, 2022
@tjni tjni deleted the fix-qtscript branch October 9, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjni @LunNova @K900 @vcunat